feat(nifi): Add NiFi OPA Authorizer #1058
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltesander
requested changes
Apr 22, 2025
| @@ -127,7 +151,7 @@ ln -s /stackable/nifi-${PRODUCT} /stackable/nifi | |||
| chown --no-dereference ${STACKABLE_USER_UID}:0 /stackable/nifi | |||
| chmod --recursive g=u /stackable/python | |||
| chmod --recursive g=u /stackable/bin | |||
| chmod g=u /stackable/nifi-${PRODUCT} | |||
| chmod --recursive g=u /stackable/nifi-${PRODUCT} | |||
There was a problem hiding this comment.
This recursive chmod will bloat the image. If you only want the extensions/opa-authorizer.nar chmodded please do that in the builder step.
REPOSITORY TAG IMAGE ID CREATED SIZE
oci.stackable.tech/sdp/nifi 1.28.1-stackable0.0.0-dev-opa 4647bd8fb197 7 seconds ago 5.65GB
oci.stackable.tech/sdp/nifi 1.28.1-stackable0.0.0-dev 2d7de1b048a7 38 hours ago 3.12GB
Comment on lines
+93
to
+97
| # TODO: Set to tag after new release of nifi-opa-plugin | ||
| RUN git clone --depth 1 https://github.com/DavidGitter/nifi-opa-plugin.git && \ | ||
| cd nifi-opa-plugin && \ | ||
| git reset --hard cdf8c36 && \ | ||
| git apply /stackable/nifi-framework-api-version.patch && \ |
There was a problem hiding this comment.
We probably want profiles upstream for that.
| FROM stackable/image/java-devel AS opa-authorizer-builder | ||
|
|
||
| ARG STACKABLE_USER_UID | ||
| ARG PRODUCT |
There was a problem hiding this comment.
PRODUCT is not used in this builder.
Suggested change
| ARG PRODUCT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Builds Nifi OPA Plugin from source and makes it available to NiFi as NAR file.
Currently uses a specific commit and contains a workaround patch until this PR is merged and released.
Definition of Done Checklist
Tasks
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
baketo retrieve the image tag for<image-tagged-with-the-major-version>.